Merged
Conversation
mvarendorff
force-pushed
the
feat-680-add-unit-tests-php
branch
from
3f84287 to
1113efa
Compare
mvarendorff
force-pushed
the
feat-680-add-unit-tests-php
branch
from
1113efa to
b10525c
Compare
stnguyen90
approved these changes
Dec 28, 2023
lohanidamodar
approved these changes
Jan 2, 2024
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
Contributor
Author
|
Hey @gewenyu99 , thanks for the heads-up! My Discord username is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds generated unit tests to the PHP SDK.
Test Plan
Generate the SDK, install composer dependencies, then run
vendor/bin/phpunit testsin the SDK's directory.Related PRs and Issues
#680
Have you read the Contributing Guidelines on issues?
Yup
Discord username for swag as requested by Tessa: yestheory